[wp-trac] [WordPress Trac] #32137: Allow user-specified default image size when inserting image via Press This

WordPress Trac noreply at wordpress.org
Mon Apr 27 15:44:49 UTC 2015


#32137: Allow user-specified default image size when inserting image via Press This
--------------------------+------------------------------
 Reporter:  topdownjimmy  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Press This    |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by stephdau):

 32137.5.patch should work,but:
  * please make sure to build your patches from the repository root:
 src/...
  * `if ( $return === 'id' )` and `if (get_option('image_default_size') !=
 '' && get_option('image_default_size') != 'full')` should use Yoda
 conditions.
  * `$src_array[0]` should be checked to make sure it has the expected
 value before using it.
  * `preg_match( '/(class="[^"]+)"/',` should check for both " and ' as
 attribute delimiters.
  * might as well instantiate a varfor `get_option('image_default_size')`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32137#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list