[wp-trac] [WordPress Trac] #32118: SCRIPT_DEBUG check in print_emoji_detection_script() generating PHP Notices

[WordPress Trac]

#32118: SCRIPT_DEBUG check in  print_emoji_detection_script() generating PHP
Notices
----------------------------------------+----------------------------
 Reporter:  aut0poietic                 |       Owner:  craig-ralston
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  4.2.1
Component:  Formatting                  |     Version:  4.2
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:
----------------------------------------+----------------------------

Comment (by Craig Ralston):

 I wasn't able to replicate any JS actually breaking from the notice not
 being suppressed. @aut0poietic if you experienced different results,
 please feel free to chime in.

 32118.diff didn't include the full move from script-loader.php, my fault.
 32118-2.diff just adds the extra {{{defined('SCRIPT_DEBUG') &&}}} and
 stays out of default-constants.php

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32118#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform