[wp-trac] [WordPress Trac] #31675: register_sidebar() without `id` parameter should be _doing_it_wrong()

WordPress Trac noreply at wordpress.org
Mon Apr 6 15:36:08 UTC 2015


#31675: register_sidebar() without `id` parameter should be _doing_it_wrong()
-------------------------+--------------------------
 Reporter:  markjaquith  |       Owner:  markjaquith
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  4.2
Component:  Widgets      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+--------------------------

Comment (by markjaquith):

 @miqrogroove makes the point on #31903 that if someone with an existing
 theme sees this notice and retroactively provides a new ID for the
 sidebars, then their existing content will be inaccessible.

 So... this notice is useful when someone is '''developing a theme'''.
 We're warning them of an issue that could cause problems down the road.

 If someone has already released a theme, then yes, '''changing the IDs to
 something else''' is going to make the contents of the old IDs
 inaccessible. The solution for theme authors who messed this up is to give
 their sidebars the auto-increment IDs that WordPress already gave them. We
 could, in the notice, suggest precisely this (even providing them the ID,
 and the "name" it corresponds to).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31675#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list