[wp-trac] [WordPress Trac] #24093: WP_Meta_Query is inefficient when referencing the same keys in "OR" query

WordPress Trac noreply at wordpress.org
Tue Sep 30 02:21:14 UTC 2014


#24093: WP_Meta_Query is inefficient when referencing the same keys in "OR" query
-------------------------------------------------+-------------------------
 Reporter:  sc0ttkclark                          |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Query                                |  Release
 Severity:  normal                               |     Version:  3.5.1
 Keywords:  needs-refresh meta-query needs-      |  Resolution:
  unit-tests has-patch dev-feedback              |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by pento):

 The unit tests in #29560 are great for this ticket - they're showing a
 bunch of bugs in [attachment:24093.4.patch] that need fixing.

 I'm not particularly fussed about us changing the SQL that goes through
 the `get_meta_sql` filter (I'm in favour of deprecating all filters on
 SQL, but that's a different discussion). We should definitely at least
 warn developers that it's changing, though.

 @vprat: Could you upload your test cases to this ticket, so that we're all
 looking at the same test data?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24093#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list