[wp-trac] [WordPress Trac] #29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts

[WordPress Trac]

#29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts
-----------------------------------+--------------------
 Reporter:  MrBobDobolina          |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest omg bbq        |   Milestone:  4.0.1
Component:  Formatting             |     Version:  4.0
 Severity:  blocker                |  Resolution:
 Keywords:  wptexturize has-patch  |     Focuses:
-----------------------------------+--------------------

Comment (by kitchin):

 Miqrogroove, I did test patch 10 and all was fine. I compared it to an
 algorithm that first did the shortcode regex and then used strpos() to do
 the tag/comment parsing. The only tests that failed were the expected ones
 by doing it that way: shortcode-like text within html tags. Also tested it
 the other way (tags then shortcodes) and got expected failures. So you
 have the right tests as far as I see.

 I thought skipping internal `--` in comments would simplify things, but
 your algorithm does skip them and does not backtrack. Like you said!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29557#comment:76>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform