[wp-trac] [WordPress Trac] #29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts

WordPress Trac noreply at wordpress.org
Mon Sep 29 04:06:56 UTC 2014


#29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts
-----------------------------------+--------------------
 Reporter:  MrBobDobolina          |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest omg bbq        |   Milestone:  4.0.1
Component:  Formatting             |     Version:  4.0
 Severity:  blocker                |  Resolution:
 Keywords:  wptexturize has-patch  |     Focuses:
-----------------------------------+--------------------

Comment (by wonderboymusic):

 In [changeset:"29781"]:
 {{{
 #!CommitTicketReference repository="" revision="29781"
 The joys of `wptexturize()`:

 * Revert parts of [28773] and [28727] and [29748].
 * Do not crash PHP. Make the shortcode quantifier possessive to avoid
 backtracks.
 * Reduce backtracking in long HTML comments by 100x.
 * Do not ignore unclosed HTML comments.
 * Do not break unregistered shortcodes, e.g. `[hello attr="value"]`.
 * Do not break HTML in shortcode attributes, e.g. `[hello attr="<"]`.
 * Do not match for shortcodes when there is extra whitespace, e.g. `[
 hello ]`.
 * Add unit tests to show #12690 was not fully resolved.
 * Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.

 Adds/modifies unit tests.

 Props miqrogroove.
 See #29557.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29557#comment:75>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list