[wp-trac] [WordPress Trac] #29692: Multisite create new site return fatal error

[WordPress Trac]

#29692: Multisite create new site return fatal error
--------------------------------+----------------------------------------
 Reporter:  kkalvaa             |       Owner:  jeremyfelt
     Type:  defect (bug)        |      Status:  assigned
 Priority:  normal              |   Milestone:  4.0.1
Component:  Networks and Sites  |     Version:  4.0
 Severity:  normal              |  Resolution:
 Keywords:  reporter-feedback   |     Focuses:  administration, multisite
--------------------------------+----------------------------------------

Comment (by jeremyfelt):

 I can't reproduce the error with PHP 5.5 or 5.2 on a clean install, so
 core doesn't seem to break on the protected `WP_Roles::_init()`. I could
 see a scenario where a sudden change to protected could confuse an
 existing script that is using `install_blog()`, but I haven't yet been
 able to reproduce it. When `install_blog()` is used by core to add a new
 site, it doesn't appear to care whether `$wp_roles` is even available.

 That said, I'm mostly confused. :)

 The use of `$wp_roles->_init()` to MU in general was first added via
 [https://mu.trac.wordpress.org/changeset/543/ MU:543], this specific use
 was introduced in [https://mu.trac.wordpress.org/changeset/564/ MU:564]
 along with some error suppressing in another function around
 `$wp_roles->_init()` that evolved over time. `reinit()` was not available
 at the time.

 If we switch to the public `$wp_roles->reinit()`, we would not be making
 use of the existing `$wp_user_roles` global to set `$wp_roles->roles`. I
 don't know if that causes issues elsewhere. I can't immediately see how it
 could. This happens to be the only place left in core that uses
 `$wp_roles->_init()`. The others (also in `ms-functions.php`) were moved
 in [21485] to `$wp_roles->reinit()` due to their association with
 `switch_to_blog()`.

 @kkalvaa - Do you have any mu-plugins installed, any role management
 plugins, or any type of multisite "helper" plugin—for domain mapping,
 multiple networks, etc..,.? It would also be helpful to see the full stack
 trace if you're able to reproduce locally. Also - can you confirm that the
 error is `WP_Roles::_init()` not `WP_Roles::init()`?

 The same issue is reported on [http://www.wordpress-
 fr.net/support/viewtopic.php?pid=515270 this forum]. I haven't been able
 to find any other reports.

 I'm wondering if something else is controlling the `site-new.php` process.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29692#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform