[wp-trac] [WordPress Trac] #29528: Fresh Install 4.0 Still asks to upgrade EN_GB

[WordPress Trac]

#29528: Fresh Install 4.0 Still asks to upgrade EN_GB
-----------------------------+--------------------
 Reporter:  jag1989          |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.0.1
Component:  Upgrade/Install  |     Version:  4.0
 Severity:  normal           |  Resolution:
 Keywords:  close            |     Focuses:
-----------------------------+--------------------
Changes (by nacin):

 * milestone:  Awaiting Review => 4.0.1


Comment:

 I have this fixed on the API side, but the code is a bit dicey, so I'm
 going to sleep on it and try to deploy it tomorrow.

 Basically: Any locale that does not have a "complex" localized package
 (which is defined as having anything in /dist/ other than, at most, a
 readme, license, and a sample config file) will be whitelisted to be
 treated as essentially the same as an English package (because it is,
 minus translations). In this case, the install will only be told about the
 localized package (and thus it'll think it is up to date) and not the
 English package (and thus it won't complain about installing WP in
 English).

 It's essentially making these two responses equal-ish:
  * http://api.wordpress.org/core/version-
 check/1.7/?version=4.0&locale=es_ES&local_package=es_ES
  * http://api.wordpress.org/core/version-
 check/1.7/?version=4.0&locale=es_ES
 While also dropping the second English offer out of the first one.

 (This makes sense — it doesn't matter if you're running a localized
 package or just a locale, as long as there are no special modifications to
 the localized package.)

 This will affect #29456 slightly, but instead of upgrading to the latest
 WP core offer of 4.0-es_ES, it'll think you're running the latest version
 and you'll just hit "Update Translations" to get the updated strings. (If
 you hit Reinstall, you'll get 4.0-es_ES which will give you the localized
 readme/config-sample/license, but no one should care about this.) As per
 above, though, if you are one of those complex locales that has /dist/
 modifications or plugins that is not on the whitelist, then you will need
 to actually update core to 4.0-$locale, as the API will think you are only
 on 4.0 in English.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29528#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform