[wp-trac] [WordPress Trac] #25247: WP_Dependencies unsets a to do item when it isn't loaded

WordPress Trac noreply at wordpress.org
Sat Sep 6 19:25:07 UTC 2014


#25247: WP_Dependencies unsets a to do item when it isn't loaded
----------------------------------------+-----------------------------
 Reporter:  markoheijnen                |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  Script Loader               |     Version:  3.6
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:
----------------------------------------+-----------------------------
Changes (by nmarks):

 * keywords:  needs-unit-tests needs-patch => needs-unit-tests has-patch


Comment:

 I added a patch for this. I found that the function was adding jquery to
 the 'done' array as it doesn't have an src set (src is set on jquery-
 core).

 What's currently happening is when it is doing the footer items, jquery is
 already in the done array and it makes no attempt to load it.

 I've added a patch that checks the current group and set group (if isset)
 on the item. when adding to the done array in the !(has-src) conditional.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25247#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list