[wp-trac] [WordPress Trac] #27533: Unobtrusive JS for "Quick Edit" button at "Comments" page and others

[WordPress Trac]

#27533: Unobtrusive JS for "Quick Edit" button at "Comments" page and others
----------------------------+-----------------------------------------
 Reporter:  aubreypwd       |       Owner:  wonderboymusic
     Type:  enhancement     |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  Administration  |     Version:  3.9
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, administration
----------------------------+-----------------------------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 [28810] does a few particularly weird things:
  * It lets things bubble up to the body, rather than using a more direct
 parent like #the-comment-list or table.comments or whatever.
  * It uses a lot of unnecessary cascading: `.comment .row-actions
 .quickedit .edit-comment-inline`. Something like `.edit-comment-inline`
 should be sufficient.
  * Why does it use event.currentTarget rather than `this`?
  * commentReply ''has'' to be defined; it's in this JS file. Those checks
 were only there because it was obtrusive JS and it could have been
 triggered before this file was loaded.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27533#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform