[wp-trac] [WordPress Trac] #30534: class-phpass.php EOF and closing PHP tag

[WordPress Trac]

#30534: class-phpass.php EOF and closing PHP tag
------------------------------------+-----------------------------
 Reporter:  amandato                |      Owner:
     Type:  defect (bug)            |     Status:  new
 Priority:  normal                  |  Milestone:  Awaiting Review
Component:  Login and Registration  |    Version:  4.0.1
 Severity:  normal                  |   Keywords:
  Focuses:                          |
------------------------------------+-----------------------------
 I caught this while auditing the changes between 4.0 and 4.0.1...

 The very end of the class-phpass.php file has a new line after the ending
 ?> php tag. I looked at other files in the wp-includes folder and didn't
 see this in any of the others. I've been told one of the recommended PHP
 coding practices is to leave out the closing php tag to prevent situations
 like this. I would simply remove that carriage return and leave the
 closing ?> since a majority of the other wp-include files end with ?>, but
 I'll leave that decision to whom ever manages this obviously.

 Thanks and Happy Thanksgiving.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30534>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform