[wp-trac] [WordPress Trac] #30348: Arrow key navigation in Media Grid skips ids

WordPress Trac noreply at wordpress.org
Sun Nov 16 15:24:42 UTC 2014


#30348: Arrow key navigation in Media Grid skips ids
------------------------------+----------------------------------------
 Reporter:  UmeshSingla       |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.1
Component:  Media             |     Version:  4.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  accessibility, javascript
------------------------------+----------------------------------------
Changes (by adamsilverstein):

 * keywords:  has-patch => has-patch commit
 * milestone:  Awaiting Review => 4.1


Comment:

 @UmeshSingla - Wow, thanks for catching that! Having spent a good bit of
 time working on and testing keyboard navigation in the media grid, I'm
 embarrassed that we missed that!

 I tested your patch and verified the bug exists before applying and is
 fixed after applying. Please note that convention is to generate diffs
 from the /trunk folder, makes it a bit easier to apply them :) I
 regenerated the patch from there and also cleaned up the language
 describing the keyEvent function.

 Thanks again, great work!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30348#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list