[wp-trac] [WordPress Trac] #16383: Width of Site Address input box in network/site-new.php

WordPress Trac noreply at wordpress.org
Wed Nov 12 19:05:43 UTC 2014


#16383: Width of Site Address input box in network/site-new.php
-------------------------------------+-------------------------------------
 Reporter:  garyc40                  |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.1
Component:  Networks and Sites       |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  multisite,
  good-first-bug                     |  administration
-------------------------------------+-------------------------------------

Comment (by honeysilvas):

 Thank you for your feedback, Jeremy.  Here's the updated patch.

 Regarding:
  Would it make sense to add .site-info-php and .site-new-php before .form-
 field? I could be overthinking it too.

 It's fine with me either way.  Just let me know which you prefer and I can
 incorporate it into the patch.

 '''Some questions about inline styles:'''

 In site-info.php, line 47, there is an inline style (style="margin-
 bottom:5px;") that I can move to the CSS file. Since I am editing that
 line anyway, should I move that inline style or just leave it?

 {{{
 <input name="blog[path]" type="text" id="path" value="<?php echo esc_attr(
 $details->path ) ?>" style="margin-bottom:5px;" />
 }}}


 In site-info.php, line 48, there is another inline style
 (style="width:20px;") that I can remove.  It's barely noticeable, but the
 width makes the checkbox look weird.

 {{{
 <input type="checkbox" style="width:20px;" name="update_home_url"
 value="update" <?php if ( get_option( 'siteurl' ) == untrailingslashit(
 get_blogaddress_by_id ($id ) ) || get_option( 'home' ) ==
 untrailingslashit( get_blogaddress_by_id( $id ) ) ) echo
 'checked="checked"'; ?> /> <?php _e( 'Update <code>siteurl</code> and
 <code>home</code> as well.' ); ?>
 }}}

 I am not sure if these are within the scope of this patch.  I can leave
 these alone but I can also easily incorporate them into the patch.  What
 do you think?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16383#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list