[wp-trac] [WordPress Trac] #30240: Tell if theme is a child theme in wp-admin/network/themes.php

WordPress Trac noreply at wordpress.org
Wed Nov 12 04:32:22 UTC 2014


#30240: Tell if theme is a child theme in wp-admin/network/themes.php
-------------------------------------+-------------------------------------
 Reporter:  dpik                     |       Owner:
     Type:  feature request          |      Status:  new
 Priority:  normal                   |   Milestone:  4.1
Component:  Networks and Sites       |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug ui-       |     Focuses:  administration,
  feedback has-patch                 |  multisite
-------------------------------------+-------------------------------------
Changes (by jeremyfelt):

 * milestone:  Awaiting Review => 4.1


Comment:

 Thanks for the patch @dpik, it works well and I think it's a great
 addition. I'll personally find this useful.

 A couple tips:

 * If possible, create the patch against the root of the develop repository
 so that the patch can apply easily. This is for the convenience of any
 testers.
 * Per the [https://make.wordpress.org/core/handbook/coding-standards/php
 /#brace-style WordPress PHP coding standards], braces are used on all
 blocks, even when not required. This is admittedly confusing when a file
 being patched already has many instances of the opposite. The others can
 stay as is, but the new lines should conform to the standards.

 I'm going to let this sit for a bit to get some UI feedback.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30240#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list