[wp-trac] [WordPress Trac] #22498: Disabling Header Text should not reset Header Text Color to default

WordPress Trac noreply at wordpress.org
Thu May 29 08:22:13 UTC 2014


#22498: Disabling Header Text should not reset Header Text Color to default
------------------------------------------+-----------------------------
 Reporter:  DrewAPicture                  |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  low                           |   Milestone:  4.0
Component:  Appearance                    |     Version:  3.4.2
 Severity:  minor                         |  Resolution:
 Keywords:  ux-feedback has-patch commit  |     Focuses:  administration
------------------------------------------+-----------------------------

Comment (by kovshenin):

 This is tricky, because both options are actually one single theme mod
 called header_textcolor, which if set to "blank" hides the text. We don't
 save the previous value when updating to "blank", so there's no value to
 restore from. The behavior in the customizer seems okay unless you refresh
 after hiding the text. If you refresh then it's all the same reset to
 default.

 To address the reset issue in this ticket, we can probably store the
 actual color in a different theme mod, like [attachment:22498.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22498#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list