[wp-trac] [WordPress Trac] #27881: Compatibility with Hack

WordPress Trac noreply at wordpress.org
Mon May 19 02:49:56 UTC 2014


#27881: Compatibility with Hack
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+--------------------

Comment (by rmccue):

 Replying to [comment:10 wonderboymusic]:
 > In [changeset:"28479"]:
 > {{{
 > #!CommitTicketReference repository="" revision="28479"
 > `hackificator` complains if you call `include 'file.php'` without the
 parens, needs to be `include( 'file.php' )`
 >
 > See #27881.
 > }}}

 We should codify this as a coding standard to ensure we're consistent in
 the future; we haven't been in the past:

 {{{
 $ ~/bin/ack '^\s*(include|require)(_once)? .*;' | wc -l
      101
 $ ~/bin/ack '^\s*(include|require)(_once)\s*\(.*;' | wc -l
      294
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27881#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list