[wp-trac] [WordPress Trac] #28290: Changing _site_option functions for _network_option functions

WordPress Trac noreply at wordpress.org
Sat May 17 14:05:42 UTC 2014


#28290: Changing _site_option functions for _network_option functions
--------------------------------+------------------------------
 Reporter:  jmlapam             |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:  multisite
--------------------------------+------------------------------

Comment (by jdgrimes):

 I agree that this is confusing at first. But it's not just these
 functions. There are quite a few other places where `network` would now be
 more accurate but `site` is still used. I have the same sentiment toward
 changing these, but if we change these option functions, it really won't
 go very far toward improving core's consistency. I'd love to see `site`
 replaced with `network` everywhere in core, but it's almost impossible to
 do that and maintain backward compatibility. I think folks might favor
 this as part of a long-term project to improve core's consistency here,
 but it should really be the result of more significant changes. E.g.,
 #20651

 So yes, let's change these to `*_network_option()`, but let's not just do
 it to change the names. Find everything wrong with the old functions that
 we couldn't fix without breaking back-compat, and let's fix it in the new
 functions.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28290#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list