[wp-trac] [WordPress Trac] #28226: menu_page_url does not return correct URL on network admin

[WordPress Trac]

#28226: menu_page_url does not return correct URL on network admin
-------------------------------------------------+-------------------------
 Reporter:  norcross                             |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.0
Component:  Menus                                |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback 2nd-opinion   |     Focuses:  multisite
  needs-testing                                  |
-------------------------------------------------+-------------------------

Comment (by norcross):

 Replying to [comment:13 DrewAPicture]:
 > Using `self_admin_url()` here would be the DRY-est approach. I guess I
 don't see the benefit in duplicating 10 lines of docs and 20 lines of code
 just to change two function calls.
 >
 > Also, the `@since` should read 4.0.0 for a new function.

 I see both sides. I know there are some network admin stuff that I'm not
 too familiar with, but I've added a patch removing the new function and
 adding the `self_admin_url` to the existing function. I'm good with either
 one

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28226#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform