[wp-trac] [WordPress Trac] #22400: Remove all, or at least most, uses of extract() within WordPress

WordPress Trac noreply at wordpress.org
Tue May 13 05:47:05 UTC 2014


#22400: Remove all, or at least most, uses of extract() within WordPress
-------------------------------------------------+-------------------------
 Reporter:  Viper007Bond                         |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  General                              |  Release
 Severity:  normal                               |     Version:  3.4.2
 Keywords:  westi-likes needs-testing has-patch  |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------

Comment (by wonderboymusic):

 In [changeset:"28391"]:
 {{{
 #!CommitTicketReference repository="" revision="28391"
 Eliminate use of `extract()` in `post_tags_meta_box()` and
 `post_categories_meta_box()`.

 Both functions only need to read `taxonomy`, yet they extract every
 available variable from `$box['args']`. Even if those variables were
 useful, there is no attempt to pass them to anything, and scope in PHP
 does not allow them to be scooped up by inner functions without being
 passed directly.

 See #22400.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22400#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list