[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

WordPress Trac noreply at wordpress.org
Tue May 6 16:44:39 UTC 2014


#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28298"]:
 {{{
 #!CommitTicketReference repository="" revision="28298"
 In `attachment_submit_meta_box()`, remove dead code:

 * `$action` doesn't need to be imported.
 * `$can_publish` is set and never used, which means it doesn't need...
 * `$post_type_object` or `$post_type`, which only served `$can_publish`.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list