[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28274"]:
 {{{
 #!CommitTicketReference repository="" revision="28274"
 In `general-template.php` - remove dead code:

 * In `get_calendar()`, `$cache` is set twice. The first is useless.
 * In `wp_default_editor()`, `$user` is (accidentally) assigned in a
 condition. Since it is never used, this is unnecessary.
 * In `language_attributes()`, `$output` is set twice before it is ever
 used. The first is unnecessary.
 * In `paginate_links()`, `$n` is set twice before it is ever used. The
 first is unnecessary.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform