[wp-trac] [WordPress Trac] #28130: Saving images after editing media gives a Javascript error

[WordPress Trac]

#28130: Saving images after editing media gives a Javascript error
--------------------------------------------+------------------
 Reporter:  t4k1s                           |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  4.0
Component:  Media                           |     Version:  2.9
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch needs-testing => has-patch needs-testing commit
 * version:  trunk => 2.9
 * milestone:  Awaiting Review => 4.0


Comment:

 The parse error appears to be caused by something else.

 I can only reproduce it if manually edit `wp_save_image()` or
 `wp_save_image_file()` to emit some kind of a PHP warning, e.g. to trigger
 `_deprecated_argument()`: [source:tags/3.9/src/wp-admin/includes/image-
 edit.php#L290].

 The patch looks good though. The issue was introduced in [11965].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28130#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform