[wp-trac] [WordPress Trac] #27510: Masonry 3 compatibility issues

[WordPress Trac]

#27510: Masonry 3 compatibility issues
--------------------------------+-------------------
 Reporter:  kovshenin           |      Owner:
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  3.9
Component:  External Libraries  |    Version:  trunk
 Severity:  normal              |   Keywords:
  Focuses:  javascript          |
--------------------------------+-------------------
 I've been digging into some of the things in Masonry 3 lately and it seems
 like the upgrade can break quite a few existing themes.

 1. A quick search in the .org themes repo revealed that
 [http://pastebin.com/jaaRqjiS some themes] register their own Masonry v2
 under the `masonry` handle, which means they will automatically be bumped
 to core's standalone v3 without the shim and the jQuery dependency. I'm
 not sure how to address this.

 2. Masonry v3 removes two classes: `masonry-brick` and `masonry`. Not many
 themes used these classes and most of them bundle their own copy of
 Masonry, but there's probably at least a handful that use core's `jquery-
 masonry` and used these classes in CSS. I sent a
 [https://github.com/desandro/masonry/pull/530 patch upstream] for this.

 3. Themes that used infinite scroll used `.masonry( 'reload' );` to layout
 new appended items. This method no longer exists in v3 and the proper way
 is to `.masonry( 'reloadItems' ).masonry( 'layout' );`. I also opened a
 pull request [https://github.com/desandro/masonry/pull/531 upstream] for
 this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27510>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform