[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer

WordPress Trac noreply at wordpress.org
Mon Mar 24 19:02:14 UTC 2014


#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Appearance      |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, administration
----------------------------+-----------------------------------------

Comment (by mcsf):

 Included attachment:21785-fix-randomize.diff which fixes an issue
 introduced in [27497] where:
 - The labels for the "Randomize" buttons (as well as the "Randomizing"
 label in the Current Header preview) would not show, thus making the
 color-changing dice a very lonely one
 - The overlay close button on the corner of each user-uploaded image would
 not show

 I believe that, following some translation-related fixes, nacin wanted to
 remove the "nImage" property instead of "type" in
 wp.customize.HeaderTool.ChoiceView.prototype.extendedModel. A delete-typo,
 if you will.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list