[wp-trac] [WordPress Trac] #27451: Widget Customizer: Remove jQuery.liveFilter dependency

WordPress Trac noreply at wordpress.org
Thu Mar 20 07:00:40 UTC 2014


#27451: Widget Customizer: Remove jQuery.liveFilter dependency
-------------------------+--------------------
 Reporter:  ocean90      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.9
Component:  Appearance   |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+--------------------

Comment (by westonruter):

 @ocean90: I love how the filter now matches against both the widget name
 and description, and how the order of the terms is irrelevant. Great idea
 on combining multiple lookahead patterns.

 I found two issues:

 1. The replacement of spaces was not done globally (needs `/ /g` instead
 of `' '`), so only the order of the first two words was not significant
 2. The search term wasn't escaped for RegExp meta characters, so
 JavaScript errors could be thrown.

 Here're my revisions on your patch: https://github.com/x-team/wordpress-
 develop/commit/95c146a718b72f13419776e6dc41daa09327cbba

 Our patches combined: https://github.com/x-team/wordpress-
 develop/pull/3/files

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27451#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list