[wp-trac] [WordPress Trac] #25234: wp_create_term is defined in the wrong file

WordPress Trac noreply at wordpress.org
Mon Mar 17 20:37:14 UTC 2014


#25234: wp_create_term is defined in the wrong file
-----------------------------------+------------------------------
 Reporter:  johnbillion            |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Taxonomy               |     Version:  2.8
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch 2nd-opinion
 * milestone:  3.9 => Awaiting Review


Comment:

 wp_create_term() is kind of crappy. A "create" action should never
 silently return something existing. This seems like a bad pattern. I'd
 rather not introduce a generically named function into the main includes
 namespace. It'll just confuse new developers.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25234#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list