[wp-trac] [WordPress Trac] #27365: Upgrader bulk_upgrade() functions do not return the correct data

[WordPress Trac]

#27365: Upgrader bulk_upgrade() functions do not return the correct data
-----------------------------+--------------------
 Reporter:  chrisbliss18     |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.9
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+--------------------

Comment (by dd32):

 I was asked to weigh in on this.. Bluntly, I'm not sure if it's the right
 or wrong change. `$this->result` and `$result` can be two different things
 I think, `$result = true; $this->result = array( ..., .., ... )`.

 It could be that the logic needed is something like `$results[$plugin] = (
 true === $result && $this->result ) ? $this->result : $result;`.. but I'm
 not entirely clear myself on what either of those variables should
 contain.

 If someone can give it a good test through both the single upgrade (not
 using checkboxes to trigger the update), and bulk upgrade for core,
 plugins, and themes, hitting both failure and success cases of all, I'd
 trust this patch as-is

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27365#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform