[wp-trac] [WordPress Trac] #21963: Consolidate post insertion APIs

[WordPress Trac]

#21963: Consolidate post insertion APIs
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:
     Type:  defect (bug)                         |  wonderboymusic
 Priority:  normal                               |      Status:  reviewing
Component:  Posts, Post Types                    |   Milestone:  4.0
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-unit-tests           |  Resolution:
  3.6-early                                      |     Focuses:
-------------------------------------------------+-------------------------

Comment (by wonderboymusic):

 The original issue when we dropped this in last time was obvious once
 @kovshenin found it, he fixed it, and tests were added.

 In [attachment:21963.8.diff .8.diff]:
 * Use @kovshenin's patch ---> I tested it
 * Moved the `guid` logic outside of the attachment if/else - it should
 never be empty as per #18310. This fixes a unit test that would have
 broken when this ticket was marked closed.
 * Updated the unit test in
 `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no
 longer being empty - I can't imagine a scenario where this was ever
 desired

 Let's try this again.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21963#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform