[wp-trac] [WordPress Trac] #26971: Plugin version string "0.9.8+git" shouldn't compare to less than "0.9.8" and trigger update notifications

WordPress Trac noreply at wordpress.org
Fri Jan 31 12:44:19 UTC 2014


#26971: Plugin version string "0.9.8+git" shouldn't compare to less than "0.9.8"
and trigger update notifications
-------------------------+----------------------
 Reporter:  lkraav       |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Plugins      |     Version:  3.8
 Severity:  normal       |  Resolution:  wontfix
 Keywords:               |     Focuses:
-------------------------+----------------------
Changes (by TobiasBg):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Changing `version_compare()` behavior, e.g. with a custom function, is not
 feasible, as plugins might be relying on PHP's `version_compare()`
 behavior internally, e.g. to update DB options or whatever (although
 that's of course better done with an integer DB version variable). Those
 would still cause trouble for you, even if core's plugin version string
 comparision would change.

 You should use that `pl`/`p` approach in your version numbers of modified
 plugins.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26971#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list