[wp-trac] [WordPress Trac] #26929: add_site_option signature should match add_option signature

[WordPress Trac]

#26929: add_site_option signature should match add_option signature
------------------------------+------------------------------
 Reporter:  ChrisWiegman      |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Options and Meta  |     Version:  3.8
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  multisite
------------------------------+------------------------------

Comment (by ChrisWiegman):

 @jeremyfelt

 You're right, this is useful in only a very small subset of uses and only
 really makes the is_multisite call non-consequential. As add_site_option
 is however listed as it will fallback to add_option however this is an
 inconsistency that just didn't quite make sense to me.

 As for the deprecated parameter, my only reason for incorporating it was
 due solely to consistency. Now anyone trying to turn off autoload can
 maintain the capability and be multi-site compatible (if needed) by adding
 "site_" to the function call.

 Long term, particularly after my current project a better fix would seem
 to be to add the ability to add_site_option for site_meta as well but,
 even in my own case, the use for such a change is so limited that I
 haven't tackled it yet. For now, as 90%+ of sites my own project goes in
 are not multi-site this would be quite a benefit without the cost of the
 extra multi-site call.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26929#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform