[wp-trac] [WordPress Trac] #26555: Remove title attributes: class-wp-editor.php

[WordPress Trac]

#26555: Remove title attributes: class-wp-editor.php
--------------------------+----------------------------
 Reporter:  joedolson     |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  3.9
Component:  TinyMCE       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  accessibility
--------------------------+----------------------------

Comment (by joedolson):

 I can't see a purpose to using aria-labelledby in this context. Looking at
 the TinyMCE implementation, it's back-referencing itself for a label --
 the aria-labelledby (which is misspelled in TinyMCE, in fact), references
 it's own ID. However, the button still has no text content, so screen
 readers should fall back to using the aria-label attribute.

 I don't think this is harmful, but it does seem pointless. (Especially
 given that aria-labeledby is spelled incorrectly, and probably won't be
 picked up at all.

 I'm proposing a patch that simply uses aria-label; unless somebody chimes
 in and says that aria-labelledby is necessary here. But generally aria-
 labelledby is dependent on visual text that as control is being associated
 with.

 I'm also removing role="presentation" -- assigning that role takes
 controls out of focusable patterns; I'm not clear why those would be
 there? I think this is a problem in the TinyMCE controls, as well, as I
 can't move keyboard focus to any of those controls.

 The patch I'm attaching now is somewhat moot at the moment; it may fix
 issues for screen readers, but since I can't launch the DFW interface
 using the keyboard or navigate any part of the DFW interface using the
 keyboard, I can't test it.

 See #25111 for my previous report about keyboard focus within the DFW
 model; I'll create a separate report for keyboard access to the TinyMCE
 controls.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26555#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform