[wp-trac] [WordPress Trac] #26910: Red "unapproved" line sometimes shows on approve comments

WordPress Trac noreply at wordpress.org
Thu Jan 23 03:55:11 UTC 2014


#26910: Red "unapproved" line sometimes shows on approve comments
----------------------------+------------------------------
 Reporter:  samuelsidler    |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  lowest          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  3.8
 Severity:  trivial         |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------------------
Changes (by nacin):

 * keywords:   => has-patch


Comment:

 This was fun to track down.

 Each comment gets that arrow not by a left border, but by a background
 assigned to :before, which is position: absolute with top: 0. That top: 0
 would normally be to the top of the comment, since the comment is
 position: relative.

 However, the rule specifying position: relative is `#activity-widget #the-
 comment-list .comment`. In this case, you can see that it's actually a
 pingback, so it doesn't receive the .comment class, but the .pingback
 class. (The proper generic class is .comment-item.) Thus, top: 0 is
 relative to the next-highest relatively positioned object, which is #the-
 comment-list.

 The rule also has a background color and a padding of 12px, but it doesn't
 look like that has any ill effect.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26910#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list