[wp-trac] [WordPress Trac] #26823: wp_get_image_editor->multi_resize()

WordPress Trac noreply at wordpress.org
Tue Jan 14 16:42:34 UTC 2014


#26823: wp_get_image_editor->multi_resize()
--------------------------+------------------------------
 Reporter:  pbearne       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  3.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by pbearne):

 Replying to [comment:16 markoheijnen]:
 > We could do a check there if width and height or 0/null then it returns
 false.
 >
 > The absint isn't needed and how it is done is redundant since you are
 calling multiple times.
 > {{{if ( ! isset( $size_data['width'] ) && ! isset( $size_data['height']
 ) ) }}} should be enough then. Didn't test it.

 The Problem is that this returns false for NULL's and this should be a
 valid input as it is valid for wp_get_image_editor->resize() both should
 to match

 paul

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26823#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list