[wp-trac] [WordPress Trac] #23149: YouTube Embedding is incorrect for https:// URLs

WordPress Trac noreply at wordpress.org
Fri Jan 10 02:19:21 UTC 2014


#23149: YouTube Embedding is incorrect for https:// URLs
------------------------------------+------------------
 Reporter:  Otto42                  |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.9
Component:  Embeds                  |     Version:  3.5
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by adamsilverstein):

 Replying to [comment:16 nacin]:
 > Okay, let's do it. Maybe we should always do scheme=https, regardless of
 video.

 Yea, lets do it - keep running into this issue over and over again! I'm
 not sure about the scheme, or whether https for non https pages would be
 detrimental in any way.

 I would appreciate your tips re: unit testing. I tried to write a unit
 test for this issue and failed. I tried do_shortcode and also global
 $wp_embed; = $wp_embed->run_shortcode(
 '[embed]http://youtube.com/watch?v=AbcDeFg123[/embed]' ); all return null
 or empty strings.

 Any tips on getting embeds to fire in tests? I scoured existing tests for
 an example without luck. Point me in the right direction and I will whip
 up a test... thanks

 Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23149#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list