[wp-trac] [WordPress Trac] #30799: Scrutinizer in 4.2

WordPress Trac noreply at wordpress.org
Sat Dec 20 23:27:02 UTC 2014


#30799: Scrutinizer in 4.2
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by wonderboymusic):

 In [changeset:"30984"]:
 {{{
 #!CommitTicketReference repository="" revision="30984"
 Comment List Tables:

 * Declare `$extra_items` property
 * Since `->get_column_info()` overrides its parent's method, it doesn't
 need to set `_column_headers`, which is an undeclared property that is
 only used for caching the lookup after the first run in the parent class,
 which isn't called in the child class.
 * `$_args` in `WP_List_Table` has to be `protected` for
 `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as
 is and should probably be only available via a getter.

 See #30799.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30799#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list