[wp-trac] [WordPress Trac] #25450: remove_role() - invalid return statement

WordPress Trac noreply at wordpress.org
Mon Sep 30 19:26:51 UTC 2013


#25450: remove_role() - invalid return statement
--------------------------+------------------------------
 Reporter:  tivnet        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Users         |     Version:  2.0
 Severity:  trivial       |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by GaryJ):

 Looks sensible. No other uses of the remove_role() method or function call
 in core, and you're right in that the method that the function wraps
 doesn't return anything anyway.

 As a side note about documentation, the use of `@return void` is no longer
 part of the inline documentation standard (since the
 [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 sfd&day=2013-09-25&sort=asc#m48668 discussion] a few days ago), so that
 `@return` tag could be removed completely if the `return` keyword is
 indeed going to be removed as well.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25450#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list