[wp-trac] [WordPress Trac] #25389: Twenty Fourteen: Browser height is not filled for short content

WordPress Trac noreply at wordpress.org
Mon Sep 23 20:57:17 UTC 2013


#25389: Twenty Fourteen: Browser height is not filled for short content
-------------------------------------+--------------------
 Reporter:  wycks                    |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.8
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  2nd-opinion ui-feedback  |
-------------------------------------+--------------------

Comment (by wycks):

 Replying to [comment:2 iamtakashi]:

 I also think it's minor, I tried a patch but ran into several problems,
 it's actually quite tricky.
 The CSS hacks are not very browser compatible,  especially for >IE8 and
 the mixture of media queries. For example there is an very easy way to do
 this just using something like:


 {{{
 #secondary{height:100vh;}
 }}}

 But it's not 100% compatible: http://caniuse.com/#feat=viewport-units



 I don't like the idea of JS adjusting the DOM on the fly.

 That leaves adjusting the structure which is a larger undertaking, for
 example making sure the html, body and sidebar descendants are all set to
 100% height, this doesn't work outside the box so I will play around with
 it some more to so if it could be a simple change.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25389#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list