[wp-trac] [WordPress Trac] #25275: Checking if attachment is audio/video

[WordPress Trac]

#25275: Checking if attachment is audio/video
--------------------------+------------------------------
 Reporter:  danielpataki  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  3.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by danielpataki):

 Agreed on all counts! I will modify the code to reflect al that.

 I'll add a wp_attachment_is_type() function which uses wp_ext2type()
 internally.

 Sorry for being a bit of a dunce but I'm completely new to making patches.
 When you say "generate patches from the WordPress root", does this mean to
 diff the whole directory? I basically used: diff -u post.php post-mine.php
 > post.diff to create the diff file. Would the method to generate from the
 root be to have a vanilla copy of wordpress and another one where I make
 changes side by side and then just use this: diff -u wordpress wordpress-
 mine > wordpress-diff.

 Also, since wp_ext2type is only in alpha, do you recommend always creating
 patches from an SVN checkout of the trunk?

 Sorry for all the questions!

 Daniel

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25275#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software