[wp-trac] [WordPress Trac] #18201: Verify updates with md5 checks

WordPress Trac noreply at wordpress.org
Thu Sep 12 02:09:41 UTC 2013


#18201: Verify updates with md5 checks
-----------------------------+------------------
 Reporter:  nacin            |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  low              |   Milestone:  3.7
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+------------------

Comment (by dd32):

 * `get_home_path()` != ABSPATH. `get_home_path()` will return the parent
 directory when WordPress is installed in a subdirectory.
 * `function_exists( 'md5_file' )`, can/is md5_file actually disabled by
 any hosting providers? I can imagine some shitty hosts would.. but..
 google doesn't reveal any cases where that's being done.
 * sleep(3) ideally shouldn't be needed, a fair amount of IO time should've
 taken place between the copy and the md5, delaying 3s shouldn't cause
 issues though, as that code branch ideally shouldn't ever be hit, however
 with #25237 _copy_dir() may fail to copy a file when using FTP if a file
 write doesn't succeed, so that's more likely to happen now than
 previously.

 This code is going to be extremely hard to test properly with trunk, since
 $wp_version will not map directly to a set of hashes (for either the
 package being downloaded, or, for the installation of WordPress).

--
Ticket URL: <http://core.trac.wordpress.org/ticket/18201#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list