[wp-trac] [WordPress Trac] #25270: Search form on wp-admin/themes.php page should be POST instead of GET

[WordPress Trac]

#25270: Search form on wp-admin/themes.php page should be POST instead of GET
----------------------------+------------------
 Reporter:  Otto42          |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  3.7
Component:  Administration  |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch
 * version:  trunk => 3.4
 * milestone:  Awaiting Review => 3.7


Comment:

 Introduced in [19887].

 We've had some issues with changing GET to POST in the past and had to go
 back (#16335, #18094).

 Perhaps it's an edge case, but changing to POST here will re-introduce an
 issue similar to the one in #18094 for no-JS. Searching and filtering
 would be broken when navigating between pages if there are more themes
 found than the default `per_page` limit, which is 36 ([21768]).

 An alternative solution would be to reset `$_SERVER['REQUEST_URI']` to
 avoid the pollution of `_wp_http_referer`. We already do that in
 `plugins.php` and several other files: [source:tags/3.6/wp-
 admin/plugins.php#L23].

 See [attachment:25270.2.diff].

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25270#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software