[wp-trac] [WordPress Trac] #17092: use dirname(__file__).'/file.php' instead of './file' for includes

WordPress Trac noreply at wordpress.org
Wed Sep 11 12:34:05 UTC 2013


#17092: use dirname(__file__).'/file.php' instead of './file' for includes
-----------------------------------+--------------------
 Reporter:  ketwaroo               |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  3.7
Component:  General                |     Version:  3.1.1
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by hakre):

 if someone could please review this again and let me know into which
 direction you want to go please.

 This patch addresses valid things, if there is some matter of taste please
 let me know.

 In my understanding includes should not be done relative to the current
 working directory (as it is the case with include paths starting with `./`
 or `../`).

 If there is a an opinion different to that (not so clear with the earlier
 comments), please raise your concerns again. Include-Path searches aren't
 the case with CWD relative includes as well as the ABSPATH based ones.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/17092#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list