[wp-trac] [WordPress Trac] #25271: Notice: unitialized string offset in link-template.php

[WordPress Trac]

#25271: Notice: unitialized string offset in link-template.php
------------------------------+-----------------------------
 Reporter:  jeremyfelt        |      Owner:
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  Warnings/Notices  |    Version:  trunk
 Severity:  normal            |   Keywords:  has-patch
------------------------------+-----------------------------
 It looks like changes introduced in [25319] caused an issue with relative
 URLs in `set_url_scheme()`.

 Notice is generated first when `admin_url( 'admin-ajax.php', 'relative' )`
 is used in `script-loader.php` on
 [http://core.trac.wordpress.org/browser/trunk/src/wp-includes/script-
 loader.php?rev=25246#L280 line 280]. Two others are generated as well with
 the same pattern.

 Notice is caused because an empty string is generated for `$url` in
 `set_url_scheme()` [http://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/link-template.php?rev=25327#L2300 here].

 Attached patch checks for an empty string before looking at the first
 character.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25271>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software