[wp-trac] [WordPress Trac] #15173: duplicate calls to 'add_new_user_to_blog'

[WordPress Trac]

#15173: duplicate calls to  'add_new_user_to_blog'
------------------------------------+---------------------
 Reporter:  sboisvert               |       Owner:  nacin
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  3.6
Component:  Multisite               |     Version:
 Severity:  minor                   |  Resolution:  fixed
 Keywords:  3.2-early dev-feedback  |
------------------------------------+---------------------

Comment (by nacin):

 Looking closer at this, the same three arguments (user_id, password, meta)
 are being passed to wpmu_welcome_user_notification(), passed to the
 wpmu_activate_user(), and then returned from wpmu_activate_signup(). So,
 not as alarming that $password is something actually used by a generic API
 function, which add_new_user_to_blog() is not. (Rather, there is
 add_user_to_blog() for that.)

 If someone is removing that hook, they may have still been getting the
 user added anyway, but I'm not concerned about the change there. Since
 maybe_add_existing_user_to_blog() already goes through a hook ('init',
 blah), let's keep the consistency.

 In all, this whole mess of signup code eventually needs cleanup one of
 these days. At that point, I imagine new functions and program flow.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15173#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software