[wp-trac] [WordPress Trac] #20220: add test to see if sunrise === on in ms-settings

[WordPress Trac]

#20220: add test to see if sunrise === on in ms-settings
-------------------------+----------------------
 Reporter:  sboisvert    |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Multisite    |     Version:  3.0
 Severity:  normal       |  Resolution:  wontfix
 Keywords:  has-patch    |
-------------------------+----------------------

Comment (by dd32):

 Most plugins that would make use of the constant are things that are most
 likely going to be custom plugins. Ultimately if we care about backwards
 compatibility we cannot change this at all, as silly as it may seem, so
 further discussion is pretty pointless.

 I honestly agree with nacin when he says:
 > If you need to ignore SUNRISE for a particular request, then either A)
 don't define it, or B) if it's too late to not define it, just don't do
 anything in sunrise.php. WordPress doesn't skip any of its own logic when
 sunrise.php is included and does nothing. Ultimately, "We needed to
 disable sunrise for certain requests." is just not enough to justify
 20220.patch​ or the like.

 Define the constant when it's needed, otherwise, do nothing.. It's the act
 of defining a constant that we care about here, not what you define it to.
 It should be pretty obvious to a developer straight away that defining it
 to false isn't doing what they expect.

 The closest we'd get to altering the values you can define it to, is to
 create a new constant instead (ie. `USE_SUNRISE`) and only define SUNRISE
 for backwards compatibility if that's defined to `true` - but doing this
 provides no tangible benefit other than adding a constant and people
 getting confused as to why there's two (and then defining both..)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/20220#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software