[wp-trac] [WordPress Trac] #23569: Network Admin Email description falsely claims e-mails will be sent from it

WordPress Trac noreply at wordpress.org
Mon Dec 2 20:12:31 UTC 2013


#23569: Network Admin Email description falsely claims e-mails will be sent from it
--------------------------+-----------------------
 Reporter:  iandunn       |       Owner:  westi
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.8
Component:  Text Changes  |     Version:
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by iandunn):

 Good catch. I looked again and there's also
 `wpmu_welcome_user_notification()` and `wp-admin/network/site-new.php`.
 What's the reasoning behind those using a different `From` header than all
 the other e-mails Core sends out? I couldn't glean anything from the
 source or commit messages.

 I'm guessing it's because with Multisite it's more important to
 distinguish between individual blogs in a network, but that's still
 relevant to multiple single-site installations, too, though. e.g., your
 inbox can have five different e-mails from five different websites, but
 they'll all show up as from "WordPress" because most mail clients only
 display the `From` name, not the `From` address.

 Also, forging the header with the admin's e-mail is probably a bad idea
 because it'll make the e-mail look like spam,
 [http://stackoverflow.com/a/4728446/450127 unless we also set the Sender
 header] -- but even that will still cause problems with some hosts (#5007,
 #2532, #1532, #14888, etc).

 Would it be better to do something like this instead?

 * Remove the custom `From` header from these functions
 * Set the default From name in `wp_mail()` as `get_option( 'blogname' )`,
 rather than "WordPress"
 * Always leave the default From address as `wordpress@$sitename`.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23569#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list