[wp-trac] [WordPress Trac] #16379: Better UI for doing "Page on Front"

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 14 22:27:00 UTC 2012


#16379: Better UI for doing "Page on Front"
--------------------------------------------+------------------
 Reporter:  markjaquith                     |       Owner:
     Type:  task (blessed)                  |      Status:  new
 Priority:  normal                          |   Milestone:  3.5
Component:  Administration                  |     Version:  3.1
 Severity:  normal                          |  Resolution:
 Keywords:  3.5-early jane-likes has-patch  |
--------------------------------------------+------------------

Comment (by SergeyBiryukov):

 [attachment:16379.4.patch] is the refreshed and revised patch.

 Replying to [comment:42 lessbloat]:
 > - When you initially click "Show a page instead of your latest posts",
 the second option should be checked by default:
 http://cl.ly/image/2A1e38413O47

 Fixed.

 > - In _dropdown_pages() the "selected" equals get_option( 'page_on_front'
 ).  Do we need to do some validation on this to make sure that the page
 that was previously set as get_option( 'page_on_front' ) still exists.

 We don't currently validate that in `options-reading.php`.
 `Walker_PageDropdown` can handle zero `'selected'` value.

 There's a related block in `wp_delete_post()` which deletes the option
 when deleting the page: [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.4.2/wp-
 includes/post.php#L2052

 Looking into customizer integration.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16379#comment:49>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list