[wp-trac] [WordPress Trac] #22221: get_custom_header() does not handle a default registered header

WordPress Trac noreply at wordpress.org
Thu Oct 18 17:10:49 UTC 2012


#22221: get_custom_header() does not handle a default registered header
-------------------+--------------------------
 Reporter:  nacin  |       Type:  defect (bug)
   Status:  new    |   Priority:  normal
Milestone:  3.5    |  Component:  Appearance
  Version:         |   Severity:  normal
 Keywords:         |
-------------------+--------------------------
 get_custom_header() handles two sources of data: the data of a random
 header image, and the saved header_image_data theme mod.

 Before a theme is saved, header_image_data is not populated. If the theme
 has a default-image rather than a random-default, get_custom_header() will
 end up having no values for 'url' or 'thumbnail_url'.

 Attached patch fixes that. Ideally, some logic in custom-header.php, this
 new logic, and the logic in _get_random_header_data() should come together
 in a much nicer way.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22221>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list