[wp-trac] [WordPress Trac] #22085: Correctly assign post_parent to uploaded attachments in the new media modal

[WordPress Trac]

#22085: Correctly assign post_parent to uploaded attachments in the new media modal
------------------------------+-----------------------
 Reporter:  koopersmith       |       Owner:  nacin
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  3.5
Component:  Media             |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by mdgl):

 Tested patch this morning and it seems to be getting us there.  A bit
 difficult to tell completely because of numerous other issues, so perhaps
 best wait until media stabilises a bit before taking another look:

 1) Upload new image from media library "add new", click "edit" to set
 caption opens a '''new''' window (why?), enter caption and hit "Publish"
 generates AYS message for leaving the page (this is in IE9 by the way).

 2) Create new post and enter some text to introduce image, leave cursor at
 end of post, hit "Add Media" and select/insert previously uploaded image
 using attachment URL. Image is inserted at '''beginning''' of post, not at
 position of cursor. Save/update post.

 3) Verify image is inserted correctly, hyperlink is correct, image is now
 "attached" to post.

 Further discussion on what we were trying to achieve by "de-emphasising"
 attachment would be useful. This looks impractical if we are to preserve
 back-compat so perhaps also need to consider reverting #22439.

 Looking at debug log after testing contains traces of other issues
 (probably due to unrelated activity): undefined "post_id" at line 1935 in
 ajax-actions.php, various "fopen" failures with redirection limit reached
 and 404 not found for attachments and failing to enable crypto for cron
 (via https? - hmnnn). Will reexamine those later on.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22085#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software