[wp-trac] [WordPress Trac] #22587: Cast image sizes to array before looping

[WordPress Trac]

#22587: Cast image sizes to array before looping
------------------------------+------------------------------
 Reporter:  griffinjt         |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Warnings/Notices  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------------------

Comment (by JustinSainton):

 Replying to [comment:4 MikeSchinkel]:
 > Replying to [comment:3 scribu]:
 > > So, your argument is "we should do it because we do it in a lot of
 other places". Not a very big improvement, is it?
 >
 > Why always so hostile?  I wonder how many good developers have given up
 contributing on Trac because they get tired of people telling them their
 suggestions are stupid?

 I wouldn't necessarily consider his comments hostile.  And he never called
 the suggestion stupid, to be fair.  He just asked if my argument was that
 "we should do it because we do it in a lot of other places".  And
 basically, that is my argument.

 Scribu might think that's a dumb argument (I think consistency is actually
 a pretty good argument) - but he never said that.  And it could be easily
 argued that there are three times as many instances that don't type-hint.
 I just happen to think it's a good practice.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22587#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software