[wp-trac] [WordPress Trac] #22456: Audit the admin with JavaScript off

WordPress Trac noreply at wordpress.org
Tue Nov 20 17:44:43 UTC 2012


#22456: Audit the admin with JavaScript off
------------------------------------+------------------
 Reporter:  nacin                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.5
Component:  Accessibility           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  audit has-patch commit  |
------------------------------------+------------------

Comment (by helenyhou):

 Replying to [comment:15 TobiasBg]:

 Using CSS is semantically more correct - there's no reason the checkbox in
 `.check-column` will ever need to show without JS, because it's only
 functional via JS. Thus the practical advantage of the CSS is that it will
 work even if you do a custom column that uses the `cb` callback. It's not
 uncommon to see code like:

 {{{
 function my_cpt_edit_columns( $columns ) {
         $columns = array(
                 'cb' => '<input type="checkbox" />',
                 'title' => 'Name',
         );

         return $columns;
 }
 }}}

 If you use `.hide-if-no-js`, then devs have to add that class to their
 markup as well, even if using the core-defined column callback (which is
 where the `.check-column` class comes from). Also, the updates screen uses
 these select all checkboxes, which were not accounted for in earlier
 patches, but are taken care of with this method.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22456#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list